Is your fix committed ? -----Message d'origine----- De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] la part de Patrick Lightbody Envoye : mardi 18 novembre 2003 07:41 A : [EMAIL PROTECTED] Objet : RE: [OS-webwork] Latest xwork cvs snapshot
Richard, I've fixed this. The down side of all this is that if you have null as an arg to a method call, the optimizations I made to get monthlist from 4X to 2X will be lost. In the future I could probably get those optimizations back, but for now this works and is really simple. -Pat -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Fred Lamuette Sent: Monday, November 17, 2003 9:37 AM To: [EMAIL PROTECTED] Subject: RE: [OS-webwork] Latest xwork cvs snapshot Jira is down for the while, but as soon as possible, I'm gonna to open a jira issue. As far as I have seen your code improvment, I believe it will appreciably increase the speed. Pat, what about the real problem that Ognl 2.6.4 should fix ? Do you wait for the next release of Ognl ? Richard. -----Message d'origine----- De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] la part de Patrick Lightbody Envoye : lundi 17 novembre 2003 17:08 A : [EMAIL PROTECTED] Objet : RE: [OS-webwork] Latest xwork cvs snapshot Richard, Thanks, I wasn't expecting a null argument. I'll need to fix that. This change was an optimization that got us from 4X to 2X speed difference in the monthlist tests. Anyway, please open a bug and I'll get to it promptly. -Pat -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Fred Lamuette Sent: Monday, November 17, 2003 5:56 AM To: [EMAIL PROTECTED] Subject: [OS-webwork] Latest xwork cvs snapshot I guess many refactorings happens in xwork (possibly to fix invalid methods ?) , especially in CompoundRootAccessor, and my current code is not working. The following example doesnt work anymore : stack.findValue("format(myDate)"). The error comes from the fact that the (Object[] objects ) argument passed to the CompoundRootAccessor.callMethod(...) is an array of size 1 containing a null object. Thus, the getArgTypes(objects) throws a NPE. Hope it can help. Richard. ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF. Net email is sponsored by: GoToMyPC GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free! https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork