Hi Alon, 2012/5/13 Alon Bar-Lev <alon.bar...@gmail.com>: > On Sun, May 13, 2012 at 9:10 PM, Gert Doering <g...@greenie.muc.de> wrote: >> Huh? You're the master of Autoconf, and I'm sure you will be able to >> produce a working PAM detection for those platforms that have it. > > Yes, and as such I tell you that automatic detection is something that > leads to package breakage.
How does PAM detection relate to the question whether to split out the plugin? Wouldn't the plugin's configure also need to detect PAM? As already discussed previously, I much prefer configure to notice a missing development package than to run into a failing "make" run. And why would automatic pam detection lead to package breakage? Have an option for enabling / disabling plugins. If a plugin is enabled and needs PAM, check for the existence of PAM. If PAM isn't found, exit configure and tell the user to pass the proper paths for pam headers and libraries. >>> >> These plugins should be optional I don't see any value in enforcing >>> >> them and their dependencies. >>> > >>> > If these plugins are useful for a large number of users, there is no >>> > point in not installing them by default. >>> >>> They are not. >> >> Unfounded claim. > > I know one or two installations, and I am tracking this project more > than 6 years. > Come on! most of installations are plain public key without any of > these plugins. > There is no need for these if you configure your server. > I simply don't understand your attitude... sorry, I simply don't. As already mentioned elsewhere in this thread, the currently included plugins aren't a huge burden to maintain. So even if we were to agree that most people don't need them by default, I would suggest to change the build default, not throw them out of the repository. I can see where the purity of the split-out would appeal to you, but the increased number of separate repositories, releases, packages, etc. to maintain forms a strong counter-point in my opinion. So I'm against splitting out the plugins for now. (Just saw Eric's openvpn-contrib proposal. Might serve as a compromise, but then we'd still lose the purity advantage ...) Cheers Fabian
