Hi, On Fri, Dec 23, 2016 at 04:23:48PM -0500, Selva Nair wrote: > nl_after_semicolon > (I know no one here writes x=1; y=2; z= 3; on the same line,
Well... looking at route.c, seems I've been guilty of a few such
cases...
But then, I'm not sure I consider this necessarily a "MUST CHANGE!"
bad style:
route.c: msg(M_WARN|M_ERRNO, "GDG6: socket() failed" ); goto done;
route.c: msg(M_WARN|M_ERRNO, "GDG6: send() failed" ); goto done;
route.c: msg(M_WARN|M_ERRNO, "GDG6: recv() failed" ); goto done;
(that's your typical "talk to weird APIs with lots of system calls that
supposedly never fail but you need to check the return code for each
of them anyway, as they *could*" code ugliness...)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
