On 23-12-16 22:23, Selva Nair wrote:
> 
> On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger <stef...@karger.me
> <mailto:stef...@karger.me>> wrote:
> 
>     diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf
>     index 95e0b2a..3745ed0 100644
>     --- a/dev-tools/uncrustify.conf
>     +++ b/dev-tools/uncrustify.conf
>     @@ -9,6 +9,7 @@ nl_brace_else=add
>      nl_elseif_brace=add
>      nl_else_brace=add
>      nl_else_if=remove
>     +nl_for_brace=add
> 
> 
> What about 
> 
> nl_switch_brace = add
> nl_while_brace = add
> nl_fdef_brace = add
> 
> These are not optional as per the style, are they?

Indeed.  Let's add them too.  I'll send a v2.

> nl_after_semicolon 
> (I know no one here writes x=1; y=2; z= 3; on the same line, 
> but assuming we do not want such usage in patches....)

Even though I do agree with this, we never discussed this.  So I'd like
to separate this discussion from the clearly defined 'align braces'.

-Steffan

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to