On 23-12-16 22:44, Steffan Karger wrote:
> On 23-12-16 22:23, Selva Nair wrote:
>>
>> On Fri, Dec 23, 2016 at 3:26 PM, Steffan Karger <stef...@karger.me
>> <mailto:stef...@karger.me>> wrote:
>>
>> diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf
>> index 95e0b2a..3745ed0 100644
>> --- a/dev-tools/uncrustify.conf
>> +++ b/dev-tools/uncrustify.conf
>> @@ -9,6 +9,7 @@ nl_brace_else=add
>> nl_elseif_brace=add
>> nl_else_brace=add
>> nl_else_if=remove
>> +nl_for_brace=add
>>
>>
>> What about
>>
>> nl_switch_brace = add
>> nl_while_brace = add
>> nl_fdef_brace = add
>>
>> These are not optional as per the style, are they?
>
> Indeed. Let's add them too. I'll send a v2.
Hrmpf, yet another can of worms. If I add these and check the changes,
it looks like we need these too:
mod_full_brace_while=add
mod_full_brace_for=add
Otherwise we get a number of
while(i) i--;
type of lines converted to
while(i)
i--;
instead of
while(i)
{
i--;
}
I'll send a patch so people can easily see what adding these means for
the code.
-Steffan
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
