Your patch has been applied to the master branch.
Since this introduces a new library requirement, I gave it a test run
on my Ubuntu 16 / MinGW linux build system. "Builds fine". Have not run
the result.
I have not done anything resembling proper code review. Just basic
"this is only changing _WIN32 code, and doesn't seem to do bad stuff
with pointers".
What I do not really like is the inflation of the code with
if (!tt->wintun)
statements now. I think this should be refactored out into an
"open_tun_wintun()" and an "open_tun_tap_windows()" function, where
all the bits that are now inside an "if (!tt->wintun)" get their
own function with less if() and less nesting.
commit e64b4a9e68bde3cb7d878d277878fb2805040e3e
Author: Lev Stipakov
Date: Thu Nov 7 19:45:25 2019 +0200
wintun: implement opening wintun device
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Simon Rozman <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg19029.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
