Your patch has been applied to the master branch.

Fixed the "char *foo" comment Selva had on the fly.

Test built on Ubuntu 1604/mingw.  No further tests.

Stared a bit at the code.  Not sure I like the way this overloads
v4/v6 into the same function just to be able to share a bit of common
code (at the expense of lots of conditionals which make the resulting
function not easy to read, and a local variable "ifconfig_ip_local"
which could be IPv4 or IPv6 now).  Antonio has just *separated*
IPv4 and IPv6 ifconfig into two independent functions to make the code 
more readable...

commit ef9b34044ec354902cd24bbcee244c6a494b6c7c
Author: Lev Stipakov
Date:   Tue Nov 12 16:44:00 2019 +0200

     wintun: clear adapter settings on tun close

     Signed-off-by: Lev Stipakov <l...@openvpn.net>
     Acked-by: Selva Nair <selva.n...@gmail.com>
     Message-Id: <20191112144400.1359-1-lstipa...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19124.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to