Acked-by: Gert Doering <g...@greenie.muc.de>

It's the same code change as in v1, just the comment rewritten as Arne 
asked for (I found the other one okay-ish, but this is more in line with 
our other code, and indeed "less thinking required on read") and a new
helper variable for the total length.

Code looks good, test build on Ubuntu 18/MingW also had no complaints.

Your patch has been applied to the master branch.

commit ef5b922aedead7159718ddbf40fc9f5be1b2b203
Author: Simon Rozman via Openvpn-devel
Date:   Mon Mar 22 08:43:59 2021 +0100

     tapctl: Resolve MSVC C4996 warnings

     Signed-off-by: Simon Rozman <si...@rozman.si>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20210322074359.527-1-si...@rozman.si>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21774.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to