Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email )
Change subject: t_client.sh: Allow to skip tests ...................................................................... Patch Set 2: (2 comments) File tests/t_client.sh.in: http://gerrit.openvpn.net/c/openvpn/+/521/comment/c1be2335_8f5e8256 : PS2, Line 301: SKIP_ > I am probably clueless about this, but where is $SKIP filled? Like all the other test settings this is defined in the t_client.rc. I can add an example to t_client.rc-sample File tests/unit_tests/openvpn/mock_msg.c: http://gerrit.openvpn.net/c/openvpn/+/521/comment/0cb16f2d_9efcdae7 : PS2, Line 94: endif > I wonder if mock_msg.c is the right place for assert_failed(). […] assert_failed is defined in error.c like all the other functions mocked here, so it seems like a natural place. The alternatives I saw for my patch were: - duplicate mock_msg.c outside of unit_tests/openvpn. But except for assert_failed this works perfectly fine. - try to use original error.c. But that pulls in a lot of platform code. We could look into split out all the complex msg stuff from error.c into its own msg.c. Then we could use error.c in the tests and mock less stuff here. - move assert_failed to its own mock_assert.c. The current solution seems slightly simpler. But that would obviously be a possible alternative if we don't like the NO_CMOCKA define. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ea6752c8d102eabcc579e391828c05d5322899 Gerrit-Change-Number: 521 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 21 Feb 2024 10:47:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
