Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email )
Change subject: t_client.sh: Allow to skip tests ...................................................................... Patch Set 2: (4 comments) File src/openvpn/error.h: http://gerrit.openvpn.net/c/openvpn/+/521/comment/79ea4054_64ee021d : PS2, Line 39: #endif > I don't like this, for two reasons - we protect unistd. […] Acknowledged File tests/t_client.sh.in: http://gerrit.openvpn.net/c/openvpn/+/521/comment/d9c095ee_2955765a : PS2, Line 301: SKIP_ > Having an example would certainly help people setting this up for their first > time. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/521/comment/df742960_4d92cd9b : PS2, Line 325: eval $test_check_skip || { > while this certainly works, the `|| {` style is quite different from the very > traditional `if/then/f […] Acknowledged File tests/unit_tests/openvpn/mock_msg.c: http://gerrit.openvpn.net/c/openvpn/+/521/comment/91fc1e95_73420afd : PS2, Line 94: endif > Not sure I understand why we have cmocka specific . […] Yes, in this PR it is now used in t_client context, which is not a unit test context -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ea6752c8d102eabcc579e391828c05d5322899 Gerrit-Change-Number: 521 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:36:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
