Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email )
Change subject: t_client.sh: Allow to skip tests ...................................................................... Patch Set 2: Code-Review-1 (5 comments) Patchset: PS2: I think this is a useful patch but there seems to be a bit of friction to overcome :-) File src/openvpn/error.h: http://gerrit.openvpn.net/c/openvpn/+/521/comment/509f59c6_11cebc44 : PS2, Line 39: #endif I don't like this, for two reasons - we protect unistd.h via `HAVE_UNISTD_H`, not via "not windows", and also this is really a separate project, moving out includes from `"syshead.h"` to the parent C file because some compilers complain. File tests/t_client.sh.in: http://gerrit.openvpn.net/c/openvpn/+/521/comment/4d712547_a890cc8a : PS2, Line 301: SKIP_ > Like all the other test settings this is defined in the t_client.rc. […] Having an example would certainly help people setting this up for their first time. http://gerrit.openvpn.net/c/openvpn/+/521/comment/71a3de91_936dd75e : PS2, Line 325: eval $test_check_skip || { while this certainly works, the `|| {` style is quite different from the very traditional `if/then/fi` style of the rest of the script. So I'm a bit undecided what to think about it. ``` if eval $test_check_skip ; then : else output ... ... fi ``` is not as compact, but might be easier to grok? File tests/unit_tests/openvpn/mock_msg.c: http://gerrit.openvpn.net/c/openvpn/+/521/comment/4daebdcf_1d3501b2 : PS2, Line 94: endif > assert_failed is defined in error. […] Not sure I understand why we have cmocka specific .c files with #ifdef NO_CMOCKA? Is this ever used outside the unit test context? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ea6752c8d102eabcc579e391828c05d5322899 Gerrit-Change-Number: 521 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 28 Feb 2024 10:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
