Attention is currently required from: flichtenheld, plaisthos. selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )
Change subject: dns: correctly handle dnssec settings ...................................................................... Patch Set 1: (1 comment) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/1643/comment/b6e006cc_47bdfb38?usp=email : PS1, Line 127: nrpt_flags_t flags; > The enum type is now really not appropriate anymore. […] We have always wanted to keep openvpn-msg.h as a standalone header that third part programs may want to use, so we need to define the flag type in there right? May be we could get rid of th one in dns.h and use the flags directly to set server->dnssec, but not sure how clean that would be. Also, in future dns flags may learn new bit fields that are unrelated to dnssec. Valid value for message flags is what openvpn-msg.h says, and using that correctly is not that onerous a requirement, is it? Unless I misunderstood the comment. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe Gerrit-Change-Number: 1643 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2026 12:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
