Attention is currently required from: d12fk, plaisthos, selvanair. flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )
Change subject: dns: correctly handle dnssec settings ...................................................................... Patch Set 1: (2 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/1643/comment/a0719312_f7f3e02b?usp=email : PS1, Line 114: nrpt_dnssec_required = 1 << 1, > Shall we treat "optional" as "no" on Windows and document that? NRPT seems to have two separate settings `DnsSecEnabled` and `DnsSecValidationRequired`. If optional maps well to `DnsSecEnabled=True`/`DnsSecValidationRequired=False` we could use it. I assume that is what your patch is currently doing? OTOH given that the broken version is already out there maybe we should go for the minimal patch first? I.e. keep the existing boolean and just enable it for DNS_SECURITY_YES and nothing else. And then we can discuss a followup patch that would support "optional". http://gerrit.openvpn.net/c/openvpn/+/1643/comment/e5891691_5e2d0dde?usp=email : PS1, Line 127: nrpt_flags_t flags; > We cant move those defines to openvpn-msg.h as we need them on non-windows as > well. […] I don't see how you can get all of that. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe Gerrit-Change-Number: 1643 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Attention: selvanair <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2026 16:27:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: d12fk <[email protected]> Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
