Attention is currently required from: d12fk, plaisthos, selvanair. flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )
Change subject: dns: correctly handle dnssec settings ...................................................................... Patch Set 1: (1 comment) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/1643/comment/8ee219d8_22c9eccb?usp=email : PS1, Line 127: nrpt_flags_t flags; > We have always wanted to keep openvpn-msg. […] I was questioning whether it is clean to set a variable of an enum type to a value that is not a named constant in that type. E.g. the new code might set flags to "3", but that is not a named value in nrpt_flags_t. Not sure whether there are compilers that complain about that. Still feels unclean. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe Gerrit-Change-Number: 1643 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Attention: selvanair <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2026 15:01:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
