Attention is currently required from: its_Giaan, ordex. cron2 has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email )
Change subject: mudp: send HMAC reset reply synchronously ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1702/comment/6862dd78_2dcdbb54?usp=email : PS1, Line 70: msg(D_MULTI_DEBUG, "Reset packet from client, sending HMAC based reset challenge"); having this `msg()` *after* we already sent out the packet does not make sense -> this should go upwards, either before or after the `msg_set_prefix()` but definitely before the `process_outgoing_link()`. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2df0fec786184b9fcf9b7c56c74816325cdb6942 Gerrit-Change-Number: 1702 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 07:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
