Attention is currently required from: cron2, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( 
http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email )

Change subject: mudp: send HMAC reset reply synchronously
......................................................................


Patch Set 2:

(2 comments)

File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1702/comment/050409ab_49c408e4?usp=email :
PS1, Line 61:      * dropping on EAGAIN is acceptable as the client retransmits 
its HARD_RESET. */
> Also, I would reduce this comment to focus on "what we do", not "how we did 
> it in the past, which di […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1702/comment/1fbca709_dfbaaa38?usp=email :
PS1, Line 70:     msg(D_MULTI_DEBUG, "Reset packet from client, sending HMAC 
based reset challenge");
> having this `msg()` *after* we already sent out the packet does not make 
> sense -> this should go upw […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2df0fec786184b9fcf9b7c56c74816325cdb6942
Gerrit-Change-Number: 1702
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Tue, 09 Jun 2026 07:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to