Attention is currently required from: its_Giaan, ordex. cron2 has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email )
Change subject: mudp: send HMAC reset reply synchronously ...................................................................... Patch Set 1: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1702/comment/19e74ef5_09f25a8d?usp=email : PS1, Line 61: * dropping on EAGAIN is acceptable as the client retransmits its HARD_RESET. */ Also, I would reduce this comment to focus on "what we do", not "how we did it in the past, which did not work" - of course one could make it work asynchronously (just create deep copies of `from`, `aux_buf`, `sock`). So maybe something ``` /* we do not want to keep any state here, anywhere, so we just send the * reply to the initial packet synchronously, without queueing anything. * Should we hit EAGAIN on a busy socket, the packet would get lost, and * the client needs to retransmit its HARD_RESET - which is considered * an acceptable compromise for managing server resources under attack. */ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1702?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2df0fec786184b9fcf9b7c56c74816325cdb6942 Gerrit-Change-Number: 1702 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 07:30:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
