Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )
Change subject: Use OpenSSL's SIPHASH implementation to double check our implementation ...................................................................... Patch Set 28: Code-Review-1 (5 comments) Patchset: PS20: > I changed the commit to only double our implement (or AWS LC) and also > removed the whole context stu […] Acknowledged File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/31/comment/7c17fa3c_8c8925c9?usp=email : PS28, Line 801: target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH) Does this still do anything? File tests/unit_tests/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/31/comment/e3e08277_ebd09952?usp=email : PS28, Line 102: -DPREFER_OPENSSL_SIPHASH \ Does this still do anything? File tests/unit_tests/openvpn/siphash_openssl.h: http://gerrit.openvpn.net/c/openvpn/+/31/comment/3f47a563_e861ae7d?usp=email : PS28, Line 2: * SipHash reference C implementation Wrong copyright header File tests/unit_tests/openvpn/siphash_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/31/comment/54f0abd7_e9a26545?usp=email : PS28, Line 35: * implementation, so we only use for unit testing that our impelmentation "use it" "implementation" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Gerrit-PatchSet: 28 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 10:08:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
