Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )
Change subject: Use OpenSSL's SIPHASH implementation to double check our implementation ...................................................................... Patch Set 30: Code-Review+2 (4 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/31/comment/9105e2b1_f784d6bb?usp=email : PS28, Line 801: target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH) > Does this still do anything? Done File tests/unit_tests/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/31/comment/13bc8e15_e9fb0f81?usp=email : PS28, Line 102: -DPREFER_OPENSSL_SIPHASH \ > Does this still do anything? Done File tests/unit_tests/openvpn/siphash_openssl.h: http://gerrit.openvpn.net/c/openvpn/+/31/comment/c2a5f74c_9ec317f0?usp=email : PS28, Line 2: * SipHash reference C implementation > Wrong copyright header Done File tests/unit_tests/openvpn/siphash_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/31/comment/e652f08a_7890d92e?usp=email : PS28, Line 35: * implementation, so we only use for unit testing that our impelmentation > "use it" […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Gerrit-PatchSet: 30 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:23:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
