plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )
Change subject: Use OpenSSL's SIPHASH implementation to double check our implementation ...................................................................... Patch Set 31: (4 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/31/comment/d73fbd06_86c1cfda?usp=email : PS28, Line 801: target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH) > Does this still do anything? Done. Removed File tests/unit_tests/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/31/comment/e41f1e6b_00a12cee?usp=email : PS28, Line 102: -DPREFER_OPENSSL_SIPHASH \ > Does this still do anything? Acknowledged. Removed. File tests/unit_tests/openvpn/siphash_openssl.h: http://gerrit.openvpn.net/c/openvpn/+/31/comment/0c92809c_403132bd?usp=email : PS28, Line 2: * SipHash reference C implementation > Wrong copyright header Done File tests/unit_tests/openvpn/siphash_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/31/comment/ec1e29bf_2fa77d39?usp=email : PS28, Line 35: * implementation, so we only use for unit testing that our impelmentation > "use it" […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Gerrit-PatchSet: 31 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Comment-Date: Sat, 08 Aug 2026 12:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
