Luigi Mantellini wrote: > Hi All, > > I rebased the patch on the last tr...@17618 the external-toolchain > patch in the main line. > > best regards, > > luigi I reviewed and tested your patch and I noticed a few problems with it:
This patch chunk looks very wrong to me: @@ -35,6 +37,7 @@ endif define Package/base-files SECTION:=base CATEGORY:=Base system + DEPENDS:=...@!native_toolchain TITLE:=Base filesystem for OpenWrt URL:=http://openwrt.org/ VERSION:=$(PKG_RELEASE)-$(REVISION) @@ -64,7 +67,6 @@ endef define Package/gcc/Default SECTION:=libs CATEGORY:=Base system - DEPENDS:=...@!native_toolchain URL:=http://gcc.gnu.org/ VERSION:=$(LIBGCC_VERSION)-$(PKG_RELEASE) endef When applying your patch and running a build (after make oldconfig), it replaces the binutils (and probably gcc as well, didn't check) version with 'unknown' and thus fails to build. Probably something's screwed up in the NEED_TOOLCHAIN config symbol logic. Maybe it would be better to invert it and give it a different name. Additionally the Package/*/config sections that you added do not add dependencies on the packages that they belong to, so they will not be grouped together with the package. I suggest either moving those config options to the toolchain section (which might be more intuitive for people wanting to configure this stuff) or to add the appropriate dependencies. - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
