Hi,

The changes you proposed for dae-handling sounds ok to me.

On Mon, Nov 26, 2007 at 12:59:00AM -0000, Roger James wrote:
> Here is the first pass at my proposed changes. I have not put the Google
> compatibility and transparency handling on output in yet but most of the
> other stuff is in there.
> 
>  
> 
> I have cleaned up the file/URI handling and added support for UNC names.
>   
> 
> The reader now returns some extra information about scaling and orientation.
> 
>  
> 
> Mattias, I am not convinced about the use of std::auto_ptr to return
> information from the plugin I have followed your convention but I still
> think passing things through a void pointer will cause memory leaks.
> 

I'm not completely happy with that auto_ptr neither, been thinking about
making a submission for fixing this and adding more generalised data
handling (Robert mentioned some about thison osg-submissions before), but 
I haven't gotten around to do it yet, been busy days lately.

The reason for passing back that filename was that it could be stored under a
different path (since the plugin had it's way with the filename).
Now with your changes regarding file/uri handling the need for passing back 
the path to the document might no longer be needed (need to look more at the 
code
before I can say for sure).

Nice work.


/ Mattias

_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to