hi Robert, > .... are changes for changes sake rather than likely to make any functional difference
I knew you will have comments ;-). It works just fine with these changes but yes, you are right - quick and somewhat dirty. So can you look at it or you want to do a ping-pong code review with my changes by your advice? :-) Please let me know Nick On Mon, Jul 9, 2018 at 1:09 PM Robert Osfield <robert.osfi...@gmail.com> wrote: > Hi Nick, > > I had a quick look at your changes and it seems to be like most of > them are changes for changes sake rather than likely to make any > functional difference. For non ascii char support I think what you'd > actually want to do is change the XmllNode::Input::string _buffer > member var to a std::vector<int> _buffer, and have the > Input::readAllDataIntoBuffer() method be adapted to read the file > accepting only chars greater than 0 rather than limiting to the ascii > 0 to 255 range. > > Robert. > On Mon, 9 Jul 2018 at 11:41, Trajce Nikolov NICK > <trajce.nikolov.n...@gmail.com> wrote: > > > > Hi Robert, > > > > I am working with some localized XML files (with chars out of 0-255 > range) and at present the XML Node parsing is not suitable to manage it. > And I think the support for is important - at my case it is OpenStreetMap > with street names containing these chars. > > > > Attached is the modified source (based on the master) that fixes ity, if > you have time and will to review. I can do PR if you want > > > > Thanks and cheers! > > > > Nick > > > > p.s. welcome back > > > > -- > > trajce nikolov nick > > _______________________________________________ > > osg-users mailing list > > osg-users@lists.openscenegraph.org > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > -- trajce nikolov nick
_______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org