Hi Nick, On Mon, 9 Jul 2018 at 12:26, Trajce Nikolov NICK <trajce.nikolov.n...@gmail.com> wrote: > > .... are changes for changes sake rather than likely to make any > functional difference > > I knew you will have comments ;-). It works just fine with these changes but > yes, you are right - quick and somewhat dirty. So can you look at it or you > want to do a ping-pong code review with my changes by your advice? :-)
I might be quicker just to provide a link to or attach an xml file that causes problem with the present parser, and then I can look at what happens when the present code encounters it, and how your changes affect things. As a general note, PRs/commits should be focused on addressing one issue at a time, so bundling a fix for a specific bug along with other cosmetic or other changes just confuses what is functional and what is not. It's not uncommon to have to go back to various revisions in code to see where regressions may have occurred so having commits that just wrap up a small set of associated changes is really helpful in identifying what has been changed and why. Robert. _______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org