> On Dec 13, 2017, at 3:10 PM, Ben Pfaff <b...@ovn.org> wrote:
> 
> @@ -317,16 +318,30 @@ ovsdb_log_unread(struct ovsdb_log *file)
>     file->offset = file->prev_offset;
> }
> 
> +void
> +ovsdb_log_compose_record(const struct json *json,
> +                         struct ds *header, struct ds *data)
> +{
> +    ovs_assert(json->type == JSON_OBJECT || json->type == JSON_ARRAY);
> +    ovs_assert(!header->length);
> +    ovs_assert(!data->length);

Since it asserts if 'header' or 'data' have been used, it might be worth 
mentioning in a function description.

Acked-by: Justin Pettit <jpet...@ovn.org>

--Justin


_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to