> On Dec 13, 2017, at 3:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in > index 694a7abed46d..2e2df5e5aa7f 100644 > --- a/ovsdb/ovsdb-client.1.in > +++ b/ovsdb/ovsdb-client.1.in > @@ -30,6 +30,9 @@ ovsdb\-client \- command-line interface to > \fBovsdb-server\fR(1) > \fBovsdb\-client \fR[\fIoptions\fR] \fBdump\fI \fR[\fIserver\fR] > \fR[\fIdatabase\fR]\fR [\fItable\fR > [\fIcolumn\fR...]] > .br > +\fBovsdb\-client \fR[\fIoptions\fR] > +\fBbackup\fI \fR[\fIserver\fR] \fR[\fIdatabase\fR] > \fIsnapshot\fR
Is the first "\fI" doing anything? Same question about the third "\fR". I think some of this is a copy/paste from the other prototypes. I don't think they make a visual difference, but those lines are pretty complicated, so it might be nice to simplify them if possible. > @@ -138,6 +141,21 @@ and prints it on stdout as a series of tables. If > \fItable\fR is > specified, only that table is retrieved. If at least one \fIcolumn\fR > is specified, only those columns are retrieved. > . > +.IP "\fBbackup\fI \fR[\fIserver\fR] \fR[\fIdatabase\fR] > \fIsnapshot\fR" Same question about simplifying the markup. > +Connects to \fIserver\fR, retrieves a snapshot of the schema and data > +in \fIdatabase\fR, and prints it on stdout in the format used for > +OVSDB standalone and active-backup database. This is an appropriate That sentence reads a little funny to me. Maybe make "database" plural? Acked-by: Justin Pettit <jpet...@ovn.org> --Justin _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
