On Thu, Dec 14, 2017 at 12:18:16PM -0800, Justin Pettit wrote:
>
> > On Dec 13, 2017, at 3:10 PM, Ben Pfaff <b...@ovn.org> wrote:
> >
> > @@ -317,16 +318,30 @@ ovsdb_log_unread(struct ovsdb_log *file)
> > file->offset = file->prev_offset;
> > }
> >
> > +void
> > +ovsdb_log_compose_record(const struct json *json,
> > + struct ds *header, struct ds *data)
> > +{
> > + ovs_assert(json->type == JSON_OBJECT || json->type == JSON_ARRAY);
> > + ovs_assert(!header->length);
> > + ovs_assert(!data->length);
>
> Since it asserts if 'header' or 'data' have been used, it might be worth
> mentioning in a function description.
Thanks, good idea. Done.
> Acked-by: Justin Pettit <jpet...@ovn.org>
I applied this to master.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
