On 5 Dec 2023, at 15:56, Ilya Maximets wrote:
> On 12/5/23 15:38, Eelco Chaudron wrote: >> >> >> On 28 Nov 2023, at 8:52, Eelco Chaudron wrote: >> >>> On 27 Nov 2023, at 19:16, Ilya Maximets wrote: >>> >>>> On 11/27/23 13:41, Eelco Chaudron wrote: >>>>> I ran 80 series of full tests, and the following tests showed failures: >>>> >>>> Hi, Eelco. >>>> >>>> It looks like this patch should go before enabling the actual testing. >>>> Some of the previous patches in the sat failed CI because of these issues. >>> >>> ACK I noticed too, will move this be one of the first patches. >>>>> >>>>> 802.1ad - vlan_limit >>>>> +2023-11-20T10:32:11.245Z|00001|dpif_netdev(revalidator5)|ERR|internal >>>>> error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0), >>>>> in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0), >>>>> >>>>> packet_type(ns=0,id=0),eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b), >>>>> eth_type(0x88a8),vlan(vid=4094,pcp=0),encap(eth_type(0x8100), >>>>> vlan(vid=100,pcp=0),encap(eth_type(0x86dd),ipv6( >>>>> src=::,dst=ff02::1:ff46:681b,label=0,proto=58,tclass=0,hlimit=255, >>>>> frag=no),icmpv6(type=135,code=0),nd(target=fe80::407e:4bff:fe46:681b, >>>>> sll=00:00:00:00:00:00,tll=00:00:00:00:00:00))) >>>>> >>>>> +2023-11-20T10:32:11.245Z|00002|dpif(revalidator5)|WARN|netdev@ovs-netdev: >>>>> failed to put[modify] (Invalid argument) >>>>> ufid:ef1ca90c-dbd0-4ca7-9869-411bdffd1ece recirc_id(0),dp_hash(0/0), >>>>> >>>>> skb_priority(0/0),in_port(2),skb_mark(0/0),ct_state(0/0),ct_zone(0/0), >>>>> ct_mark(0/0),ct_label(0/0),packet_type(ns=0,id=0), >>>>> eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),eth_type(0x88a8), >>>>> vlan(vid=4094,pcp=0/0x0),encap(eth_type(0x8100), >>>>> vlan(vid=100/0x0,pcp=0/0x0),encap(eth_type(0x86dd), >>>>> ipv6(src=::/::,dst=ff02::1:ff46:681b/::,label=0/0,proto=58/0, >>>>> tclass=0/0,hlimit=255/0,frag=no),icmpv6(type=135/0,code=0/0), >>>>> nd(target=fe80::407e:4bff:fe46:681b/::, >>>>> sll=00:00:00:00:00:00/00:00:00:00:00:00, >>>>> tll=00:00:00:00:00:00/00:00:00:00:00:00))), actions:drop >>>> >>>> BTW, we should be able to fix this test now, since David fixed the >>>> revalidator pause/resume logic. >>> >>> Let me take a look at the test. I am not sure how to verify as I can not >>> make it fail easily. >>> >> >> Looked at this, but it’s not revalidator related, it’s formatting done by >> the userspace part. > > Well, yes, but formatting is done by the revalidator and this > formatting/parsing depends on the vlan_limit configuration. > We just need to avoid the race between revalidation and the > flow removal from the datapath. That was my initial thought also so I made some changes to the netdev-specific function dpif_netdev_mask_from_nlattrs/dpif_netdev_flow_from_nlattrs (in line with what was done for tc). But it did not seem to solve the problem. I’ll work on this outside of this patchset, and exclude it for now. >> >> Tried to replicate this but was not successful outside of GitHub actions. >> Will add this to my TODO, and revisit it later. For now will keep it >> excluded in this patch set. >> >> >> //Eelco >> >> <SNIP> >> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
