ChenSammi commented on a change in pull request #291: HDDS-1574 Average out
pipeline allocation on datanodes and add metrcs/test
URL: https://github.com/apache/hadoop-ozone/pull/291#discussion_r354263266
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java
##########
@@ -197,12 +196,17 @@ public Pipeline create(ReplicationFactor factor) throws
IOException {
@Override
public Pipeline create(ReplicationFactor factor,
List<DatanodeDetails> nodes) {
+ int nodeIdHash = 0;
+ if (factor == ReplicationFactor.THREE) {
+ nodeIdHash =
RatisPipelineUtils.encodeNodeIdsOfFactorThreePipeline(nodes);
+ }
Review comment:
Hash computation is missed in another create function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
