ChenSammi commented on a change in pull request #291: HDDS-1574 Average out
pipeline allocation on datanodes and add metrcs/test
URL: https://github.com/apache/hadoop-ozone/pull/291#discussion_r354270609
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -162,6 +183,15 @@ public synchronized Pipeline
createPipeline(ReplicationType type,
if (pipeline.isOpen()) {
metrics.incNumPipelineCreated();
metrics.createPerPipelineMetrics(pipeline);
+ for (int i = 0; i < checkPipelineContainSameDatanodes(pipeline); i++) {
+ metrics.incNumPipelineContainSameDatanodes();
+ //TODO remove until pipeline allocation is proved equally
distributed.
+ LOG.info("Pipeline contains same datanodes as previous pipeline." +
+ " PipelineId:" + pipeline.getId().toString() +
+ " nodeIds: " + pipeline.getNodes().get(0).getUuid().toString() +
+ ", " + pipeline.getNodes().get(1).getUuid().toString() +
+ ", " + pipeline.getNodes().get(2).getUuid().toString());
Review comment:
Suggest also log the overlapped pipeline ID, besides the current pipeline ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
