ChenSammi commented on a change in pull request #291: HDDS-1574 Average out 
pipeline allocation on datanodes and add metrcs/test
URL: https://github.com/apache/hadoop-ozone/pull/291#discussion_r355821778
 
 

 ##########
 File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
 ##########
 @@ -162,6 +183,16 @@ public synchronized Pipeline 
createPipeline(ReplicationType type,
       if (pipeline.isOpen()) {
         metrics.incNumPipelineCreated();
         metrics.createPerPipelineMetrics(pipeline);
+        if (RatisPipelineUtils.checkPipelineContainSameDatanodes(
 
 Review comment:
   There are another case of pipeline open, through openPipeline API. You 
should add the same logic there. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to