https://bugzilla.redhat.com/show_bug.cgi?id=1056057
--- Comment #2 from Debarshi Ray <debars...@redhat.com> --- (In reply to Kenjiro Nakayama from comment #1) > (This is not official review.) > > I don't know why you wrote the Source0 like this. > > > # This URL: > > https://github.com/01org/dleyna-server/archive/v%{version}.tar.gz > > # will create a dleyna-server-%{version}.tar.gz file > > Source0: %{name}-%{version}.tar.gz > > If you have your code archive on your github, shouldn't you write url like > [1]? > > [1] https://fedoraproject.org/wiki/Packaging:SourceURL#Github The format suggested in the guidelines do not really work. https://github.com/$OWNER/$PROJECT/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz does not refer to a valid location if I replace $OWNER with 01org and $PROJECT with dleyna-server. But mentioning the commit hash corresponding to the release sounds like a good idea, so I have done that. Spec: http://rishi.fedorapeople.org/dleyna-server.spec SRPM: http://rishi.fedorapeople.org/dleyna-server-0.4.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
