https://bugzilla.redhat.com/show_bug.cgi?id=1056057
Kalev Lember <kalevlem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |kalevlem...@gmail.com
Flags| |fedora-review+
--- Comment #3 from Kalev Lember <kalevlem...@gmail.com> ---
Fedora review dleyna-server-0.4.0-2.fc20.src.rpm 2014-02-14
$ rpmlint dleyna-server \
dleyna-server-debuginfo \
dleyna-server-0.4.0-2.fc20.src.rpm
dleyna-server.src: W: invalid-url Source0: dleyna-server-0.4.0.tar.gz
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ OK
! needs attention
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file handles locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
Looks good to me, just a small issue with the Source URL. As yaneti pointed out
on IRC, the way to make the github URLs work (as recommended in the packaging
guidelines) would be to use the git hash that the tag points to. Right now you
are using the hash of the tag object; should be the hash that the commit points
to.
$ git show-ref --dereference v0.4.0
0e9d8bd48f80daea4f352a33ba1aa35af180dd46 refs/tags/v0.4.0
3fcae066b44195c187b5611acfd511b9a87850d0 refs/tags/v0.4.0^{}
^^ e.g. the 2nd hash here.
This is just a minor issue and won't block the package from getting imported,
but would be great if you could fix it so that 'spectool -g' starts working.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
