https://bugzilla.redhat.com/show_bug.cgi?id=1116238
Alan Pevec <ape...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(slinaber@redhat.c
| |om)
--- Comment #4 from Alan Pevec <ape...@redhat.com> ---
Few quickfixes needed (from fedora-review --bug 1116238 --mock-config
fedora-rawhide-x86_64):
- Package contains BR: python2-devel or python3-devel
see https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
=> add BuildRequires: python2-devel
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/openstack-tempest-icehouse
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
=> why %dir %attr(0755, %{username}, %{username}) /usr/share/%{name}
leave only /usr/share/%{name}
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
=> tarball has LICENSE, %doc LICENSE in %files section will fix this
but please run fedora-review yourself and examine licensecheck.txt
Also check rpmlint output:
E: explicit-lib-dependency python-httplib2
=> see above
W: non-standard-group System/Management
=> just remove Group: it's not used in Fedora
W: no-documentation
=> see above, %doc LICENSE should make this rule happy
W: hidden-file-or-dir /usr/share/openstack-tempest-icehouse/.mailmap
=> remove
W: hidden-file-or-dir /usr/share/openstack-tempest-icehouse/.coveragerc
=> remove
E: zero-length /usr/share/openstack-tempest-icehouse/etc/whitelist.yaml
=> why does upstream have that empty file?? Shouldn't it have at least a
comment explaining what is it about?
E: non-executable-script
/usr/share/openstack-tempest-icehouse/tempest/stress/cleanup.py 0644L
/usr/bin/env
=> propose +x upstream?
W: hidden-file-or-dir /usr/share/openstack-tempest-icehouse/.testr.conf
=> remove
W: non-standard-uid /usr/share/openstack-tempest-icehouse %{username}
=> what is %{username} ??
W: non-standard-gid /usr/share/openstack-tempest-icehouse %{username}
=> what is %{username} ??
W: empty-%pre
=> remove that section is not needed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
