https://bugzilla.redhat.com/show_bug.cgi?id=1186889
--- Comment #5 from Philip Prindeville <phil...@redfish-solutions.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> This in not EPEL material, you can drop the compat cruft:
>
> # Noarch subpackages available from Fedora 10, RHEL 6
> %global noarch_subpkgs 0%{?fedora} > 9 || 0%{?rhel} > 5
>
> rm -rf %{buildroot}
I need to remove the 'rm' as well?
And why not get this into EPEL? A lot of CentOS users run mail servers with
SpamAssassin, MIMEDefang, and perl-Geo-IP...
> Something strange happens with the provides:
> Provides: %{name}-cron = %{version}-%{release}
> Obsoletes: %{name}-cron < %{version}-%{release}
> This is implied, no need to add it.
Fixed.
> There's no need to talk about non-Linux (or even non-Fedora) in the package
> description. Remove "Currently the program only supports Linux and
> other Unix- like systems."
Actually, that was cut & pasted verbatim from website's description of the
package. I figured it was simplest to keep the description in the authors'
words.
> Also, you don't need to copy ${SOURCE1} twice. Just install it directly in
> %install.
Fixed.
> Otherwise looks OK.
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
