https://bugzilla.redhat.com/show_bug.cgi?id=1186889



--- Comment #6 from Paul Howarth <p...@city-fan.org> ---
(In reply to Philip Prindeville from comment #5)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> > This in not EPEL material, you can drop the compat cruft:
> > 
> >   # Noarch subpackages available from Fedora 10, RHEL 6
> >   %global noarch_subpkgs 0%{?fedora} > 9 || 0%{?rhel} > 5
> > 
> >   rm -rf %{buildroot}
> 
> I need to remove the 'rm' as well?
> 
> And why not get this into EPEL?  A lot of CentOS users run mail servers with
> SpamAssassin, MIMEDefang, and perl-Geo-IP...

If you've any intention of updating EPEL to GeoIP 1.6.x then this is a must for
those EPEL branches, as GeoIP would need to depend on it (this was split off
from GeoIP at 1.6).

> > There's no need to talk about non-Linux (or even non-Fedora) in the package
> > description. Remove "Currently the program only supports Linux and
> > other Unix- like systems."
> 
> Actually, that was cut & pasted verbatim from website's description of the
> package.  I figured it was simplest to keep the description in the authors'
> words.

It's probably not worth keeping anything not relevant to Fedora/EPEL users.

Hopefully I'll have time to take a look at this tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to