https://bugzilla.redhat.com/show_bug.cgi?id=1358215

Jan Chaloupka <jchal...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jchal...@redhat.com



--- Comment #4 from Jan Chaloupka <jchal...@redhat.com> ---
Would be handy to at least:

%global provider        github
%global provider_tld    com 
%global project         direnv
%global repo            direnv
# https://github.com/direnv/direnv
%global provider_prefix %{provider}.%{provider_tld}/%{project}/%{repo}
%global import_path     %{provider_prefix}
%global commit          2bb2df4ca3bf3f45d1f36372c279615239e5c0f4

The commit is important so automatic tooling can scan your spec file and
connect the code with commit and repository.

Then use

# e.g. el6 has ppc64 arch without gcc-go, so EA tag is required
ExclusiveArch:  %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 %{arm}}
# If go_compiler is not set to 1, there is no virtual provide. Use golang
instead.
BuildRequires:  %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang}

instead of

ExclusiveArch: %{go_arches}
BuildRequires: compiler(go-compiler)

to make it portable to other architectures. %{go_arches} is not defined
everywhere, the same holds for the compiler(go-compiler)

There are no devel packages so no need for devel subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to