https://bugzilla.redhat.com/show_bug.cgi?id=1358215
--- Comment #7 from Dominic Cleal <domi...@cleal.org> --- (In reply to Jan Chaloupka from comment #6) > >> The commit is important so automatic tooling can scan your spec file and > >> connect the code with commit and repository. > > > Can you elaborate on this please? The spec file doesn't built a particular > > upstream commit, it only uses official releases, so I'm not sure that > > hardcoding SHAs into the spec file makes sense. > > The release itself is important for rpm's NVR. It is easier to search for > commit macro in the spec file rather then parsing package release version > and then detecting the corresponding commit from it. What requires the corresponding commit to be recorded? I'm not aware of this in Fedora spec files generally, only when not using a release (https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services). It doesn't feel like it belongs here, the version number to commit is part of upstream's process, not packaging. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
