https://bugzilla.redhat.com/show_bug.cgi?id=1358215
Dominic Cleal <dcl...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |dcl...@redhat.com
--- Comment #5 from Dominic Cleal <dcl...@redhat.com> ---
Thanks for the review, updated the spec/SRPM:
Spec URL: https://fedorapeople.org/~domcleal/reviews/direnv/direnv.spec
SRPM URL:
https://fedorapeople.org/~domcleal/reviews/direnv/direnv-2.9.0-2.fc26.src.rpm
(In reply to Dusty Mabe from comment #3)
> [!]: Uses parallel make %{?_smp_mflags} macro.
>
> DWM: Maybe consider adding this flag to your call to make?
> https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
Thanks, fixed in -2 for the main build (not %check).
(In reply to Jan Chaloupka from comment #4)
> Would be handy to at least:
>
> %global provider github
> %global provider_tld com
> %global project direnv
> %global repo direnv
> # https://github.com/direnv/direnv
> %global provider_prefix %{provider}.%{provider_tld}/%{project}/%{repo}
> %global import_path %{provider_prefix}
> %global commit 2bb2df4ca3bf3f45d1f36372c279615239e5c0f4
>
> The commit is important so automatic tooling can scan your spec file and
> connect the code with commit and repository.
Can you elaborate on this please? The spec file doesn't built a particular
upstream commit, it only uses official releases, so I'm not sure that
hardcoding SHAs into the spec file makes sense.
> Then use
>
> # e.g. el6 has ppc64 arch without gcc-go, so EA tag is required
> ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64
> %{arm}}
> # If go_compiler is not set to 1, there is no virtual provide. Use golang
> instead.
> BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang}
>
> instead of
>
> ExclusiveArch: %{go_arches}
> BuildRequires: compiler(go-compiler)
>
> to make it portable to other architectures. %{go_arches} is not defined
> everywhere, the same holds for the compiler(go-compiler)
Thanks, fixed in -2.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
