https://bugzilla.redhat.com/show_bug.cgi?id=2384214
--- Comment #16 from Benson Muite <[email protected]> --- (In reply to John Wason from comment #12) > > I have made the requested changes: > > a) I have disabled s390x builds. This architecture is not used in my > industry. Ok. It is helpful to determine why it does not build, but not a must. > > b) Tests have been enabled Thanks. > > c) The documentation uses packages that are only available on PyPi so they > are not available here The package that is missing is sphinx_toolbox https://github.com/robotraconteur/robotraconteur/blob/master/docs/getting_started/conf.py#L18C6-L18C20 The project: https://github.com/sphinx-toolbox/sphinx-toolbox seems well maintained, but has a lot of dependencies not in Fedora. Would you consider a pull request to use: https://github.com/dgarcia360/sphinx-collapse instead? C# documentation requires packages not in Fedora, but C# bindings are not built, so not very helpful to also ship this. > > d) I have disabled pregenerated sources and added SWIG as a dependency. The > sources are needed by some platforms so are in the tarball. > Thanks. > e) Done Thanks. > > f) Done > Thanks. > g) Done Thanks. > > This package uses the Apache 2.0 license which handles the patent license > issue. Ok. The patent is available at: https://patents.google.com/patent/US10536560B2/en My understanding from https://opensource.com/article/18/2/apache-2-patent-license is that people can still use and distribute the library without fee. Additional comments: Python and C++ libraries that are linked to do not need to be listed in the Requires field, the tooling will pull these in. See the output at https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2384214-robotraconteur/fedora-rawhide-x86_64/10185608-robotraconteur/fedora-review/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2384214 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202384214%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
