https://bugzilla.redhat.com/show_bug.cgi?id=2384214
--- Comment #18 from Benson Muite <[email protected]> --- (In reply to John Wason from comment #17) > The sphinx-collapse package https://github.com/dgarcia360/sphinx-collapse > seems to work fine, but I do not want to maintain the fedora package. I can > add a fedora patch that removes the collapse tags to remove the requirement. > It is only used in a few places. > Ok. Have generally preferred to ship documentation in docbook form, rather than HTML. Doxygen can generate docbook directly, sphinx can generate texinfo which can then be transformed to docbook. Shipping documentation is not a must, but can be helpful for users. Would suggest creating a noarch documentation sub-package if you choose to ship documentation. sphinx-collapse is not packaged, but I would be happy to package it. Not willing to package all dependencies for sphinx-toolbox. > Three of the libraries bluez-libs, dbus, libusb1 are dynamically loaded so > they will need to be included in the package spec. They will not be detected > by the linker. Yes you are correct. ldd librobotraconteurcore 1-1.2.7-1.fc45.x86_64.rpm/usr/lib64/libRobotRaconteurCore.so.1 linux-vdso.so.1 (0x00007fa6241aa000) libboost_filesystem.so.1.90.0 => not found libboost_thread.so.1.90.0 => not found libboost_random.so.1.90.0 => not found libboost_program_options.so.1.90.0 => not found libssl.so.3 => /lib64/libssl.so.3 (0x00007fa623715000) libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007fa623000000) libboost_chrono.so.1.90.0 => not found libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fa622c00000) libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fa624141000) libc.so.6 => /lib64/libc.so.6 (0x00007fa622a0d000) libz.so.1 => /lib64/libz.so.1 (0x00007fa624117000) libm.so.6 => /lib64/libm.so.6 (0x00007fa623620000) /lib64/ld-linux-x86-64.so.2 (0x00007fa6241ac000) If they are indicated as required by librobotraconteurcore1 anything that uses it will pull these in. It is linked to by the Python library, so bluez-libs, dbus, libusb1 do not need to be listed as required by the Python library. > > I see the dependencies for librobotraconteur-devel commented out. How would > this work? > > %package -n librobotraconteur-devel > Summary: Robot Raconteur development files > #Requires: librobotraconteurcore1, robotraconteurgen boost-devel >= > 1.58.0, cmake, g++, gcc, make, openssl-devel Would expect just: Requires: librobotraconteurcore1%{?_isa} = %{version}-%{release} Why is robotraconteurgen needed for development? Why are cmake, g++, gcc and make required? Anyone using this may choose to use other build tools. Why are boost-devel and openssl-devel required? C++ devel packages typically just include header files, shared libraries without sonames and CMake and/or pkgconfig files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2384214 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202384214%23c18 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
