Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809882 --- Comment #3 from Tim Bielawa <tbiel...@redhat.com> 2012-04-17 13:30:10 EDT --- Spec URL: http://people.redhat.com/~tbielawa/ansible/ansible.spec SRPM URL: http://people.redhat.com/~tbielawa/ansible/ansible-0.0.2-1.fc16.src.rpm Description: Ansible is a radically simple model-driven configuration management, multi-node deployment, and remote task execution system. Ansible works over SSH and does not require any software or daemons to be installed on remote nodes. Extension modules can be written in any language and are transferred to managed machines automatically. (In reply to comment #1) > Hi, > > a few note : > - you should explicitely say the version of python to use in BuildRequires > https://fedoraproject.org/wiki/Packaging:Python#BuildRequires Fixed. > - the python macro are already defined on Fedora, so no need to add them again Fixed. Only set if RHEL 5. (We're targeting that in the future) > - Prefix is forbidden Fixed. > - buildRoot should not be used, except for EPEL 5 > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Fixed. Only set if RHEL 5. > - so does %defattr, %clean and rm in %install I don't understand what you mean by this. Can you please expand? > - --record=INSTALLED_FILES is not used, and is not recommended > https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling Removed. > - it seems that %{_datadir}/ansible/ would end unowned I think this is fixed now. > - I am not sure, but I think that "-n %{name}-%{version}" is uneeded, becuase > tha's the default Correct. Removed this too. > - the guideline ask for consistency when using macro to reference path : > %config(noreplace) /etc/ansible/hosts > %config(noreplace) %{_sysconfdir}/ansible/ Fixed. Consolidated to just "%{_sysconfdir}/ansible" > - %{_mandir}/man1/*.gz > that's not mandatory, but I think that's better to not hardcode the prefix > used > here, as this could be changed in the future ( ie, be something else than gz ) Adjusted this too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
