Quoting brian d foy <[EMAIL PROTECTED]>: > On 5/31/07, Andy Armstrong <[EMAIL PROTECTED]> wrote: > > On 31 May 2007, at 21:42, brian d foy wrote: > > > I've just been running cpants_lint.pl before I upload anything. If it > > > doesn't say "perfect", that fails. :) > > > > Yes, damn you :) > > > > I'll volunteer for a bit of poking of Test::Kwalitee if it doesn't > > need too much. > > I looked at the RT tickets. I think three of them can be closed > immediately or re-assigned to Module::CPANTS::Analyse. Test::Kwalitee > just does wraps taht module, so if people don't like how it does the > work, it's not Test::Kwalitee's problem. > > One is a documentation patch, which is easy. > > The rest of them can probably be cleaned up by peeking into > Module::CPANTS::Analyse to get the names and descriptions of the tests > to build the %test_types hash in Test::Kwalitee. I think that's the > only thing that needs an update. I think > Module::CPANTS::Kwalitee->new->get_indicators_hash should take care of > that. >
I already did this and sent Chromatic the changes, but he hasn´t yet got round to putting the changes on CPAN. One of the issues was that some metrics are for testing the tar ball which usually doesn´t make sense in a normal testing environment. In addition, thare are some other metrics which could be deemed "optioanl". A suggestion was to have different levels of "strictness" in Test::Kwalitee and have different sets of metrics being tested by default at each of those levels. However, I didn´t get into this and simply hard-coded some of the metrics to be skipped. Nathan > I'll have some time next week if Andy doesn't beat me too it. > > > -- > brian d foy <[EMAIL PROTECTED]> > http://www.pair.com/~comdog/ >
