[PATCH] was Re: perldoc segfaulting in XS_UNIVERSAL_VERSION

[John Peacock]

John Peacock wrote:

I'm backreving to before those patches to see if the cores go away.

That was it and this fixes it for good:

=== universal.c
==================================================================
--- universal.c  (revision 17957)
+++ universal.c  (local)
@@ -338,7 +338,7 @@

     gvp = pkg ? (GV**)hv_fetch(pkg,"VERSION",7,FALSE) : Null(GV**);

-    if (gvp && isGV(gv = *gvp) && SvOK(sv = GvSV(gv))) {
+    if (gvp && isGV(gv = *gvp) && (sv = GvSV(gv)) && SvOK(sv)) {
         SV *nsv = sv_newmortal();
         sv_setsv(nsv, sv);
         sv = nsv;

HTH

John

--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748