On Wed, Jul 13, 2005 at 02:24:06PM -0400, John Peacock wrote:
> John Peacock wrote:
> >I'm backreving to before those patches to see if the cores go away.
>
> That was it and this fixes it for good:
>
> === universal.c
> ==================================================================
> --- universal.c (revision 17957)
> +++ universal.c (local)
> @@ -338,7 +338,7 @@
>
> gvp = pkg ? (GV**)hv_fetch(pkg,"VERSION",7,FALSE) : Null(GV**);
>
> - if (gvp && isGV(gv = *gvp) && SvOK(sv = GvSV(gv))) {
> + if (gvp && isGV(gv = *gvp) && (sv = GvSV(gv)) && SvOK(sv)) {
> SV *nsv = sv_newmortal();
> sv_setsv(nsv, sv);
> sv = nsv;
Thanks applied (25141)
Strangely the patch didn't want to apply automatically, so I did it by hand.
What would a regression test look like?
Nicholas Clark
