On May 10, 2004, at 5:29 PM, Tim Bunce wrote:
On Mon, May 10, 2004 at 01:40:55PM -0400, stevan little wrote:I have committed my first set of changes to the DBI svn repository.
Thanks!
I got an assortment of warnings from various tests. I suspect you didn't run a plain "make test" before the checkin (please do). I've checked in fixes for those.
I actually did run make test, and there were warnings, but they were in files I had not modified, and has been there since I first downloaded it. In particular 40profile.t was giving me trouble. I just assumed that something was under development and that was why it was breaking.
I usually do a "perl Makefile.PL && make" then I use the prove utility from Test::Harness to test as I go, then I run "make clean" and then a full "perl Makefile.PL && make && make test".
What were the warnings you saw?
This is what I get when I run make test (with the latest code from svn (333))
PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01basics............ok
6/109 skipped: various reasons
t/02dbidrv............ok
t/03handle............ok
t/04mods..............ok
t/05thrclone..........skipped
all skipped: this darwin perl 5.008 not configured to support iThreads
t/06attrs.............ok
t/07kids..............ok
t/08keeperr...........ok
t/09trace.............ok
t/10examp.............ok
t/15array.............ok
t/20meta..............ok
t/30subclass..........ok
t/40profile...........ok 37/59DBI handle cleared whilst still active at t/40profile.t line 140.
t/40profile...........NOK 40# Test 40 got: '4' (t/40profile.t at line 146)
# Expected: '5'
t/40profile...........NOK 45# Failed test 45 in t/40profile.t at line 151
t/40profile...........FAILED tests 40, 45
Failed 2/59 tests, 96.61% okay
t/41prof_dump.........ok
t/42prof_data.........ok
t/50dbm...............ok
t/60preparse..........ok
t/80proxy.............skipped
all skipped: modules required for proxy are probably not installed (e.g., RPC/PlClient.pm)
t/pod.................skipped
all skipped: Test::Pod 1.00 required for testing POD
t/zvpp_01basics.......ok
6/109 skipped: various reasons
t/zvpp_02dbidrv.......ok
7/48 skipped: various reasons
t/zvpp_03handle.......ok
t/zvpp_04mods.........ok
t/zvpp_05thrclone.....skipped
all skipped: this darwin perl 5.008 not configured to support iThreads
t/zvpp_06attrs........ok
t/zvpp_07kids.........skipped
all skipped: $h->{Kids} attribute not supported for DBI::PurePerl
t/zvpp_08keeperr......ok
t/zvpp_09trace........ok
t/zvpp_10examp........ok
38/247 skipped: various reasons
t/zvpp_15array........ok
t/zvpp_20meta.........ok
t/zvpp_30subclass.....ok
t/zvpp_40profile......skipped
all skipped: profiling not supported for DBI::PurePerl
t/zvpp_41prof_dump....skipped
all skipped: profiling not supported for DBI::PurePerl
t/zvpp_42prof_data....skipped
all skipped: profiling not supported for DBI::PurePerl
t/zvpp_50dbm..........ok
t/zvpp_60preparse.....skipped
all skipped: preparse not supported for DBI::PurePerl
t/zvpp_80proxy........skipped
all skipped: modules required for proxy are probably not installed (e.g., RPC/PlClient.pm)
Failed Test Stat Wstat Total Fail Failed List of Failed
------------------------------------------------------------------------ -------
t/40profile.t 59 2 3.39% 40 45
10 tests and 57 subtests skipped.
Failed 1/39 test scripts, 97.44% okay. 2/1830 subtests failed, 99.89% okay.
The changes have turned up a warning that ought to have been produced
before: "DBI handle cleared whilst still active at t/40profile.t line 143"
so that's a good sign. I'm fixing that now.
There of course, is still more to come. But I thought I would commit my
changes thus far.
Thanks. Please do. (Better regular chunks of changes than a few massive ones.)
Tim.
