On Thu, Aug 10, 2006 at 07:19:21PM -0700, Chip Salzenberg wrote:
> * useless curlies
>
> - if (PMC_IS_NULL(type_hash))
> + if (PMC_IS_NULL(type_hash)) {
> return core_type;
> + }
> hash = PMC_struct_val(type_hash);
> - if (!hash->entries)
> + if (!hash->entries) {
> return core_type;
> + }
>
> Something I'm hoping to stamp out is the use of curlies for all if/else
> clauses, which makes code taller without making it substantially clearer.
> I'd appreciate if you'd use a no-curlies-when-possible style.
>
> OTOH, if you don't want to do this right away, I'd be OK with a merge
> first, and fixing the curlies later.
>
> OTGH, the project needs automated filters for more coding standards,
> including one that that notes (and optionally kills) the excess curlies.This is a bad joke, right? How much of your life are you intending to spend on chasing down hard to find missing braces bugs? -J --
pgpR245EXzCsy.pgp
Description: PGP signature
