----- Original Message ----- From: "chm" <[email protected]>
To: <[email protected]>
Sent: Monday, May 07, 2012 4:54 AM
Subject: Re: [Perldl] PDL and perl 5.16.0 release testers needed


On 5/6/2012 11:49 AM, chm wrote:
Here are the links to the various tickets:

https://sourceforge.net/tracker/?func=detail&aid=3518253&group_id=612&atid=100612

https://rt.cpan.org/Public/Bug/Display.html?id=76577

I don't have 5.16 but looking at the tests, it
appears that the variables in use are globals
in package main:: and t/01_edit_distance.t is
definitely not 'use strict;' safe.

It would be interesting to see if switching to
my and 'use strict' and ensuring that the various
variables are all cleared/initialized appropriately
would cause the test to pass.

I've edited 01-distance.t to make it 'use strict;' safe.
(See attached - perhaps you had additional steps in mind. There are still some 'our' variables there.) The attached version still needs the patch that Slaven provided in order to pass on 5.16.

That patch works for me on both 32-bit and 64-bit blead, and doesn't break any of the tests in the PDL-2.4.10_003 test suite for earlier perl versions. (Checked for 5.8.9, 5.10.0, 5.12.0 and 5.14.0.)

Cheers,
Rob

Attachment: 01_distance.t
Description: Binary data

_______________________________________________
Perldl mailing list
[email protected]
http://mailman.jach.hawaii.edu/mailman/listinfo/perldl

Reply via email to