Applied. Passes all tests on the master branch. David
On Mon, May 7, 2012 at 8:34 AM, Chris Marshall <[email protected]>wrote: > Thanks for the crosscheck. I guess we can apply the > patch to master and I'll see about getting a new CPAN > developers release out in a week or so. I'll apply this > evening unless someone beats me to it. > > Cheers, > Chris > > On Mon, May 7, 2012 at 6:19 AM, Sisyphus <[email protected]> > wrote: > > > > ----- Original Message ----- From: "chm" <[email protected]> > > To: <[email protected]> > > Sent: Monday, May 07, 2012 4:54 AM > > > > Subject: Re: [Perldl] PDL and perl 5.16.0 release testers needed > > > > > >> On 5/6/2012 11:49 AM, chm wrote: > >>> > >>> Here are the links to the various tickets: > >>> > >>>> > >>>> > https://sourceforge.net/tracker/?func=detail&aid=3518253&group_id=612&atid=100612 > >>>> > >>>> https://rt.cpan.org/Public/Bug/Display.html?id=76577 > >> > >> > >> I don't have 5.16 but looking at the tests, it > >> appears that the variables in use are globals > >> in package main:: and t/01_edit_distance.t is > >> definitely not 'use strict;' safe. > >> > >> It would be interesting to see if switching to > >> my and 'use strict' and ensuring that the various > >> variables are all cleared/initialized appropriately > >> would cause the test to pass. > > > > > > I've edited 01-distance.t to make it 'use strict;' safe. > > (See attached - perhaps you had additional steps in mind. There are still > > some 'our' variables there.) > > The attached version still needs the patch that Slaven provided in order > to > > pass on 5.16. > > > > That patch works for me on both 32-bit and 64-bit blead, and doesn't > break > > any of the tests in the PDL-2.4.10_003 test suite for earlier perl > versions. > > (Checked for 5.8.9, 5.10.0, 5.12.0 and 5.14.0.) > > > > Cheers, > > Rob > > _______________________________________________ > Perldl mailing list > [email protected] > http://mailman.jach.hawaii.edu/mailman/listinfo/perldl > -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." -- Brian Kernighan
_______________________________________________ Perldl mailing list [email protected] http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
