On Wed, May 16, 2001 at 04:55:02PM +0100, Adam Spiers wrote:
> Matthew Astley ([EMAIL PROTECTED]) wrote:
> > I'm taking the "get the users to do your dirty work of pestering
> > Graham" approach. It's Lazy but perhaps not polite..?
>
> Well ... I sent him the patch on 13th February. I also reported a bug
> with Mail::Internet on 2nd April 2000 and never got a reply. Not sure
> what the correct approach is really. Maybe just another friendly
> poke?
Is it fairly obviously not going to break anything, or does it need
thinking about?
Graham's done a huge amount of perl stuff AFAICS. Presumably he's just
busy(tm)?
On Wed, May 16, 2001 at 05:55:57PM +0200, Christian Lemburg wrote:
> Not my favorite approach. I am inclined to go in Andrews direction.
> Does Andrew's approach break anything? I don't think so. In all
> of his three cases, our "if ($exception)" still has the same truth value.
> Any counterexamples I am missing?
Only example I can think of it where a user's test does
eval{testcode}. I haven't actually done this in any of mine, at least
in its current form, but I've come pretty close in some place. Usually
where I'm abusing a bit of code, of course, but letting failure slip
through undetected seems like harsh punishment for this.
> I think the other approach (diff files and requiring users to patch)
> could be a major hurdle in the install process. People just don't
> want to think about such issues.
Absolutely. Being deliberately mean isn't my favourite either.
Can we be helpful? Is it possible to shove an overload into Error.pm
(with big flashing warnings, of course) from inside our code, if we
detect an old version? I've not played with overload much.
The pragmatic solution is to patch as Andrew suggests, then write a
perlunit selftest which a) checks the functionality and b) fails with
a suggestion to revert the patch if it detects a newer Error.pm
Am I making a mountain out of a molehill here?
Matthew #8-)
_______________________________________________
Perlunit-users mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/perlunit-users
